Chore/msp 12904/smb rename #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
July 22, 2015 09:37
move some of the easiest peices into the new RubySMB TLN MSP-12904
moved Smb2 as a subnamespace to RubySMB start converting all the things MSP-12904
move all the packet classes for smb2 to the new namespace setup MSP-12904
finished cleaning up the smb2 subnamespace under lib MSP-12904
add smb2 to the rubysmb autload MSP-12904
all namespace changes complete and specs passing again MSP-12904
rename the gemspec to ruby_smb.gemspec MSP-12904
add missing CONTRIBUTING.md to the repo MSP-12904
add config file for PullReview so we can start getting pullreview commenting on pull requests MSP-12904
modified pullreview.yml to explicitly call out ruby
|
I noticed coveralls didn't finish, but Travis passed. Gonna merge, and we can fix the coveralls prob in a later commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification Steps
bundle installrake specrake specPost-merge Steps
Perform these steps prior to pushing to master or the build will be broke on master.
Version
lib/ruby_smb/version.rbPRERELEASEand its comment asPRERELEASEis not defined on master.Gem build
RSpec
rake specCommit & Push
git commit -agit push origin master