This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
Feature: Add KMS data key decryption #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmitchell-r7
reviewed
May 4, 2017
| const validResponse = { | ||
| KeyId: 'arn:aws:kms:us-east-1:ACCOUNT:key/SOME-UUID', | ||
| PlainText: Buffer.from('this-is-a-secret', 'utf8').toString('base64') | ||
| Plaintext: Buffer.from(plaintext, 'base64') |
There was a problem hiding this comment.
Why did the key name change from PlainText to Plaintext?
There was a problem hiding this comment.
Turns out I mucked it up in the original tests. The property returned from KMS.decrypt() is actually Plaintext.
fmitchell-r7
approved these changes
May 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds decryption support for secrets encrypted against data keys generated via
KMS. generateDataKey(). The initial implementation requires all secrets to be encrypted via theaes-256-cbccipher.