Changed for...in to for...of

[andrasf]

I was trying to use the library, but had fatal exceptions upon application startup.

It turned out I was using an array extension that would be hard to remove, that added a method to Array.prototype. This method shows up if an array is used with for (let i in array), but does not show up if used with for (let i of Object.keys(array)), causing side effects.

This made country-coder to crash when calling methods on arrays, eg. charAt, when it did not expect to handle anything other than strings.

[bhousel]

Whoa.. I kind of think both of these array iteration methods are pretty weird.

for..in loops over iterable keys, which in an array happens to usually (but not definitely) contain the array indexes.
for..of at least loops over the array values, but then - to use Object.keys to turn them back into keys is .. really weird.

Thanks for raising this issue, but I think I'd feel better just rewriting all these for..in loops to just use either normal for loops or normal array iterators.

[andrasf]

Thank you!