Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some things we aren't using #263

Closed
2 tasks done
bhousel opened this issue Feb 15, 2024 · 0 comments
Closed
2 tasks done

Remove some things we aren't using #263

bhousel opened this issue Feb 15, 2024 · 0 comments
Labels
chore Improvements to the code or development stack, cleanups
Milestone
1.0.0-pre.2

Comments

@bhousel
Copy link
Collaborator

bhousel commented Feb 15, 2024 •
edited

There are a few things that this sdk provides that we haven't used in a while, so they can be removed.
May update the list with more..

  • d3 projection streams
  • util functions for working with css classes
bhousel added a commit that referenced this issue Feb 15, 2024
@bhousel
Remove unused getStream to get a d3 projection stream
a8e97f5 
(re: #263)
bhousel added a commit that referenced this issue Feb 15, 2024
@bhousel
Remove various functions for generating selector lists
c05fef1 
(re: #263)

These were used back when we were d3-selecting geometry from the svg surface
for the purposes of highlighting, styling, interactivity, etc.

Since switching the renderer to WebGL, we don't do this anymore,
so generating these selector lists many different ways becomes unnecessary.
@bhousel bhousel added the chore Improvements to the code or development stack, cleanups label Feb 15, 2024
@bhousel bhousel added this to the 1.0.0-pre.2 milestone Feb 15, 2024
bhousel added a commit that referenced this issue Feb 15, 2024
@bhousel
Eliminate unneeded dependencies on d3-zoom and d3-geo
0e01acb 
(re: #263)

We were wrapping d3-mercatorRaw to do projection and inverse,
but we can just copy over the math for this.

We were using d3-zoomIdentity to set up a Transform object
but we can just make an Object with x,y,k properties.

Code in Rapid does not use the d3 methods in either of these,
and we're going to need to own more of the math once we start
rotating the map, per #264
@bhousel bhousel closed this as completed Mar 27, 2024
@bhousel bhousel mentioned this issue Apr 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Improvements to the code or development stack, cleanups
Projects
None yet
Milestone
1.0.0-pre.2
Development

No branches or pull requests
1 participant
@bhousel