experiment with builder pattern #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbachmann
commented
Nov 29, 2023
Comment on lines
+546
to
+547
| // todo this calls s1.count internally is this optimizes in the same way it | ||
| // would if we pass in self.cache.s1.len() |
There was a problem hiding this comment.
I didn't compare the assembler, but performance wise it doesn't make any noticeable difference. Would have been surprising too, since this iterator should know it's size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick experiment how the builder pattern for the API would look and how much effort it would be. At least the tags for type and score cutoff could be shared between implementations. Not really sure whether we can reduce duplication further, since these public functions should probably have documentation, which might differ between metrics. In theory I could generate a lot of this using macros, but that's not necessarily an improvement 😅