New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support every Stripe error code #15

Merged
merged 3 commits into from Jun 11, 2018

Conversation

2 participants
@FGRibreau
Contributor

FGRibreau commented Jun 10, 2018

resource_missing was... missing (tadum tiss)

and thus I added every other error code (based on https://stripe.com/docs/error-codes)

@FGRibreau FGRibreau changed the title from fix: add every Stripe error code https://stripe.com/docs/error-codes to fix: add every Stripe error code Jun 10, 2018

@FGRibreau FGRibreau changed the title from fix: add every Stripe error code to fix: support every Stripe error code Jun 10, 2018

AccountAlreadyExists,
AccountCountryInvalidAddress,
AccountInvalid,
StripeAccount,

This comment has been minimized.

@kestred

kestred Jun 11, 2018

Member

I can't find this error code (stripe_account) in the Stripe documentation.

TokenInUse,
TransfersNotAllowed,
UpstreamOrderCreationFailed,
UrlInvalid
}

This comment has been minimized.

@kestred

kestred Jun 11, 2018

Member

Probably worth using the #[doc(hidden)] __NonExhaustive pattern here since more error codes are likely in the future

BankAccountUnverified,
BitcoinUpgradeRequired,
CardDeclined,
DeclineCode,

This comment has been minimized.

@kestred

kestred Jun 11, 2018

Member

I don't believe there is a decline_code error code; Decline Codes appear to only be used on a ChargeOutcome.

IncorrectZip,
CardDeclined,
Missing,

This comment has been minimized.

@kestred

kestred Jun 11, 2018

Member

The generic missing error code was removed here, but still exists in the Stripe documentation
https://stripe.com/docs/error-codes#missing

(Should be added after LivemodeMismatch?)

ShippingCalculationFailed,
SkuInactive,
StateUnsupported,
LegalEntity,

This comment has been minimized.

@kestred

kestred Jun 11, 2018

Member

Cannot find a legal_entity error code in the stripe documentation

This comment has been minimized.

@FGRibreau

FGRibreau Jun 11, 2018

Contributor

indeed, my bad, will fix this (I extracted the error code from the page with some JS code :))

FGRibreau and others added some commits Jun 11, 2018

@kestred kestred merged commit 90946ba into rapiditynetworks:master Jun 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kestred

This comment has been minimized.

Member

kestred commented Jun 11, 2018

Published in v0.4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment