Render contact fields using labels #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling of pods with actions
| #---------------------------------------------------------------------------- | ||
| # A contact field value | ||
| #---------------------------------------------------------------------------- | ||
| directives.directive('cpFieldvalue', () -> |
There was a problem hiding this comment.
@justinvdm have added this to do formatting of date and numerical values, as we're currently just dumping ISO8601 timestamps on unfortunate users. Logic below should probably be shared in some way with pod values.
There was a problem hiding this comment.
Thanks, noted. I think the plan for the base pod's UI is to expect all item values to be strings. If we start defining custom pods with values of other types, this will come in quite useful though.
This was referenced Jul 22, 2016
rowanseymour
pushed a commit
that referenced
this pull request
Nov 18, 2016
…w-changes-languages Feature/openhelpd 100 faq review changes languages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates the styling of the contact details panel on the case page, to use same styling as that which will be used for pods provided by case plugins.
And ensures that date and numerical field values are formatted accordingly. So
becomes: