Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports for compatibility #109

Merged
merged 3 commits into from
Jan 9, 2019
Merged

Conversation

johncordeiro
Copy link
Contributor

@johncordeiro johncordeiro commented Jan 9, 2019

When using the most recent version of smartmin there are some broken imports in this project. This PR fixes that.

setup.cfg Outdated
@@ -1,6 +1,7 @@
[flake8]
exclude=./.tox/*,./env/*,*/migrations/*,./build/*
max-line-length=120
ignore=W605
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there a lot of these? can we just fix them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.219% when pulling 8be1751 on Ilhasoft:fix/login into a0361b3 on rapidpro:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.219% when pulling 8be1751 on Ilhasoft:fix/login into a0361b3 on rapidpro:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.219% when pulling 8be1751 on Ilhasoft:fix/login into a0361b3 on rapidpro:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.219% when pulling 8be1751 on Ilhasoft:fix/login into a0361b3 on rapidpro:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.219% when pulling 8be1751 on Ilhasoft:fix/login into a0361b3 on rapidpro:master.

@coveralls
Copy link

coveralls commented Jan 9, 2019

Coverage Status

Coverage remained the same at 97.219% when pulling f30705d on Ilhasoft:fix/login into a0361b3 on rapidpro:master.

@rowanseymour rowanseymour merged commit d2b5947 into rapidpro:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants