Wait for crons on shutdown #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #603 +/- ##
==========================================
+ Coverage 61.76% 62.16% +0.40%
==========================================
Files 127 127
Lines 8950 8908 -42
==========================================
+ Hits 5528 5538 +10
+ Misses 2555 2502 -53
- Partials 867 868 +1
Continue to review full report at Codecov.
|
rowanseymour
commented
Mar 16, 2022
| @@ -108,11 +109,12 @@ func main() { | |||
|
|
|||
| // handleSignals takes care of trapping quit, interrupt or terminate signals and doing the right thing | |||
| func handleSignals(mr *mailroom.Mailroom) { | |||
| sigs := make(chan os.Signal) | |||
| sigs := make(chan os.Signal, 1) | |||
There was a problem hiding this comment.
gets rid of linter warning on line below that you should us a buffered channel with signal.Notify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also simplifies the starting of cron jobs