Allow Mailroom to use AWS Credential Chains for accessing S3 #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
reviewed
Aug 2, 2022
Codecov Report
@@ Coverage Diff @@
## main #647 +/- ##
=======================================
Coverage 61.99% 62.00%
=======================================
Files 132 132
Lines 12944 12945 +1
=======================================
+ Hits 8025 8026 +1
Misses 4053 4053
Partials 866 866
Help us with your feedback. Take ten seconds to tell us how you rate us. |
rowanseymour
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user wants to enable s3 access, but doesn't want to use static key/secret values, they can set
AWSUseCredChainto true, and the AWS SDK will use its built-in credential chain (env vars, file, role, etc) to access S3.