Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add test cases for TIFF file loader module #61

Open
gigony opened this issue Jun 18, 2021 · 0 comments
Open

[FEA] Add test cases for TIFF file loader module #61

gigony opened this issue Jun 18, 2021 · 0 comments
Labels
feature request New feature or request

Comments

@gigony
Copy link
Contributor

gigony commented Jun 18, 2021

Is your feature request related to a problem? Please describe.
Add unit/integration/system/performance testing for TIFF file loader module (under clara).

  • Setup test cases for Python/C++ modules.

See https://github.com/rapidsai/cucim/wiki/002_setup_tests.md for the details.

@gigony gigony added the feature request New feature or request label Jun 18, 2021
rapids-bot bot pushed a commit that referenced this issue Jul 27, 2021
The main change is for addressing parts of #38 and #61.

- Add initial unit/perf test cases for TIFF loader
- Add license texts for python tests

This also has the following minor changes:
- Fix some typo in the doc.
- Remove cupy_rc channel in README.md
- Update name in Github templates
- Update calculation of patch_down_count

And build/doc related changes
- Update build script and contributing guide
- Fix broken links in docs
- Sort import statements by using isort

```bash
./run test                             # execute all tests
./run test python                      # execute all python tests
./run test python unit                 # execute all python unit tests
./run test python unit skimage         # execute all python unit tests in `skimage` module
./run test python unit clara           # execute all python unit tests in `clara` module
./run test python performance          # execute all python performance tests
```


Current test folder structure looks like below:

```bash
python/cucim/tests/
├── __init__.py
├── conftest.py
├── fixtures
│   └── testimage.py
├── integration
│   ├── __init__.py
│   └── clara
│       └── __init__.py
├── performance
│   ├── __init__.py
│   └── clara
│       ├── __init__.py
│       └── test_read_region_memory_usage.py
├── test_cucim.py
├── unit
│   ├── __init__.py
│   └── clara
│       ├── __init__.py
│       ├── test_image_cache.py
│       ├── test_load_image.py
│       ├── test_load_image_metadata.py
│       └── test_tiff_read_region.py
└── util
    ├── gen_image.py
    └── gen_tiff.py
```

Authors:
  - Gigon Bae (https://github.com/gigony)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Gregory R. Lee (https://github.com/grlee77)
  - https://github.com/jakirkham

URL: #62
@gigony gigony added this to To do in Feature Planning Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Feature Planning
Needs prioritizing
Status: No status
Development

No branches or pull requests

1 participant