Remove logging from digital pathology transforms #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved helper function declarations for color_jitter
This flag controls if the array is transferred back to the host
grlee77
added
improvement
gigony
approved these changes
May 31, 2022
There was a problem hiding this comment.
Looks good to me! Thanks @grlee77 for working on this on behalf of @shekhardw !
jakirkham
approved these changes
Jun 4, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #114
Removes the try/except wrappers with logging of errors from the digital pathology transforms added in #100.
Also renames a variable
to_cupytoto_numpyinstead to reflect its actual function.For reviewers: There appear to be many lines changed here, but it is mostly a change in indentation due to removal of
try/exceptblocks with_loggercalls. Also some nested function definitions withincolor_jitterwere moved outside of that function.