add whole-slide tiled read/write demos for measuring GPUDirect Storage (GDS) I/O performance #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change folder name add back missing function update paths searched for resize.tiff add description of how to obtain test data
grlee77
added
doc
gigony
approved these changes
Nov 18, 2022
Comment on lines
143
to
154
| # def get_config(self): | ||
| # # cc_config = self.compressor.get_config() if self.compressor else None | ||
| # return { | ||
| # "id": self.codec_id, | ||
| # "compressor_config": None, # cc_config, | ||
| # } | ||
|
|
||
| # @classmethod | ||
| # def from_config(cls, config): | ||
| # # cc_config = config.get("compressor_config", None) | ||
| # # compressor = get_codec(cc_config) if cc_config else None | ||
| # return cls() # compressor=compressor) |
There was a problem hiding this comment.
Can be removed? or want to keep this for other purpose?
Co-authored-by: Gigon Bae <gigony@gmail.com>
|
@gpucibot merge |
jakirkham
reviewed
Jan 20, 2023
Comment on lines
+69
to
+75
| if dtype == 'uint8': | ||
| img = image_gpu | ||
| assert img.dtype == cp.uint8 | ||
| else: | ||
| img = image_gpu.astype(dtype) | ||
| else: | ||
| raise NotImplementedError("only testing for uint8 and uint16") |
There was a problem hiding this comment.
This double else looks odd. What was intended?
Looking at the error message would have thought this
Suggested change
| if dtype == 'uint8': | |
| img = image_gpu | |
| assert img.dtype == cp.uint8 | |
| else: | |
| img = image_gpu.astype(dtype) | |
| else: | |
| raise NotImplementedError("only testing for uint8 and uint16") | |
| if dtype == 'uint8': | |
| img = image_gpu | |
| assert img.dtype == cp.uint8 | |
| elif dtype == 'uint16': | |
| img = image_gpu | |
| assert img.dtype == cp.uint16 | |
| else: | |
| raise NotImplementedError("only testing for uint8 and uint16") |
Though maybe the error is simply not needed? However then the if is probably unnecessary too
Suggested change
| if dtype == 'uint8': | |
| img = image_gpu | |
| assert img.dtype == cp.uint8 | |
| else: | |
| img = image_gpu.astype(dtype) | |
| else: | |
| raise NotImplementedError("only testing for uint8 and uint16") | |
| img = image_gpu.astype(dtype) |
There was a problem hiding this comment.
For context, I was trying to update #474 which reinstates some style checks that were disabled during the GitHub Actions transition. The Python code fails to parse because it has two else: blocks.
There was a problem hiding this comment.
Creating issue ( #484 ) to track
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These demos are intended to accompany a blog post describing tiled read and write operations of whole slide images.