add a 20 minute timeout for pytest runs on CI #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temporarily make pytest runs verbose to help diagnose an issue where pytest seems to occasionally get stuck for multiple hours
grlee77
added
bug
ajschmidt8
approved these changes
Apr 18, 2023
jakirkham
approved these changes
Apr 19, 2023
|
/merge |
|
Thanks Greg & AJ! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently some CI runs seemed to hang for multiple hours with tests at 99% complete.
This PR adds a 20 minute timeout on the pytest run to avoid this issue. I also added a verbose flag so that if things get stuck we can identify which test case may be the cause.