Do not use x86_64 GDS binaries for aarch64 #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gigon Bae <gbae@nvidia.com>
gigony
added
improvement
grlee77
approved these changes
Jul 27, 2023
| @@ -234,6 +234,30 @@ retry() { | |||
| return 0 | |||
| } | |||
|
|
|||
| get_arch() { | |||
| local platform="${1:-$(uname -p)}" | |||
There was a problem hiding this comment.
uname -m may be more portable?
I think it will mostly be x86_64 or aarch64, but it looks like there are other arm-related possibilities listed here: https://stackoverflow.com/questions/45125516/possible-values-for-uname-m
jakirkham
approved these changes
Jul 27, 2023
|
Thanks Gigon! 🙏 |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although there are no cuFile / GDS binaries for SSBA ( aarch64 ) currently, it still requires 'cufile.h' file to create a libcufile_stub library that loads libcufile dynamically.
This patch still download GDS package but do not copy GDS libraries if the architecture is
aarch64.Address #586