Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a memory leak and update release notes for v0.19.0 #9

Merged
merged 3 commits into from
Apr 15, 2021
Merged

Fix a memory leak and update release notes for v0.19.0 #9

merged 3 commits into from
Apr 15, 2021

Conversation

gigony
Copy link
Contributor

@gigony gigony commented Apr 15, 2021

  • Fix memory leak in out-of-boundary case
  • Do not depend on CuPy for root module
  • Update release notes for v0.19.0

@gigony gigony requested review from a team as code owners April 15, 2021 09:21
@gigony gigony added bug Something isn't working doc Improvements or additions to documentation breaking Introduces a breaking change and removed bug Something isn't working doc Improvements or additions to documentation labels Apr 15, 2021
grlee77
grlee77 approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gigony. This looks good to me.

python/cucim/src/cucim/__init__.py
Comment on lines -26 to -29
numpy
Functions from NumPy which are not available via CuPy.
scipy
Functions from SciPy which are not available via CuPy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for finding and removing these!

python/cucim/README.md Outdated Show resolved Hide resolved
@quasiben
Copy link
Member

I think we should merge this in to 0.20 then create a separate PR for 0.19. @rapidsai/ops do we still have time to get a hotfix in for 0.19 ?

@raydouglass
Copy link
Member

do we still have time to get a hotfix in for 0.19 ?

Sure, ideally get it in by the end of the week

@quasiben
Copy link
Member

Thanks @raydouglass . @gigony after this goes in to 0.20 we can make a separate PR with this and the doc fixes as well

@gigony
Copy link
Contributor Author

gigony commented Apr 15, 2021

after this goes in to 0.20 we can make a separate PR with this and the doc fixes as well

Thanks @raydouglass !
@quasiben Sure. Let me create a PR with this and other doc fixes once this is merged.
Thanks guys!

@jakirkham Looks like this needs your help (approval) to get merged.

@jakirkham
Copy link
Member

Thanks Gigon! 😄

@quasiben
Copy link
Member

I think we need someone from @rapidsai/ops to merge in

@raydouglass raydouglass merged commit 6cfdbfb into rapidsai:branch-0.20 Apr 15, 2021
@jakirkham
Copy link
Member

Thanks all! 😄

@jakirkham
Copy link
Member

Here's the hot fix PR ( #11 )

@gigony gigony mentioned this pull request May 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasiben quasiben quasiben approved these changes

@jakirkham jakirkham jakirkham approved these changes

@raydouglass raydouglass raydouglass approved these changes

@grlee77 grlee77 grlee77 approved these changes

Assignees
No one assigned
Labels
breaking Introduces a breaking change bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gigony @quasiben @raydouglass @jakirkham @grlee77