Skip to content

Commit

Permalink
Explicitly build for all GPU architectures (#15959)
Browse files Browse the repository at this point in the history
The libcudf conda package is not specifying to build for all supported architectures and is instead letting build.sh fall back to NATIVE. However, because the default behavior of rapids-cmake is to build SASS for all supported architectures if NATIVE is specified but no local architecture is detected, we're still ending up with all of the RAPIDS architectures having SASS built for them. The problem is that we are failing to build PTX for the latest version, which would be produced if we used RAPIDS instead of NATIVE. This PR should resolve that issue.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - James Lamb (https://github.com/jameslamb)

URL: #15959
  • Loading branch information
vyasr committed Jun 10, 2024
1 parent f9b0fc3 commit 58a15a8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion conda/recipes/libcudf/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ export cudf_ROOT="$(realpath ./cpp/build)"

./build.sh -n -v \
libcudf libcudf_kafka benchmarks tests \
--build_metrics --incl_cache_stats \
--build_metrics --incl_cache_stats --allgpuarch \
--cmake-args=\"-DCMAKE_INSTALL_LIBDIR=lib -DCUDF_ENABLE_ARROW_S3=ON\"

0 comments on commit 58a15a8

Please sign in to comment.