Skip to content

Commit

Permalink
Temporarily disable docs errors. (#15265)
Browse files Browse the repository at this point in the history
Currently there are some network issues affecting docs builds. To prevent this from causing complete CI blockage, we can temporarily allow errors in the docs build. This will allow us to monitor the network status and re-enable the docs builds when the network issues are resolved.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #15265
  • Loading branch information
bdice committed Mar 11, 2024
1 parent 6a03827 commit c794ce4
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 3 deletions.
14 changes: 13 additions & 1 deletion ci/build_docs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ rapids-mamba-retry install \

export RAPIDS_DOCS_DIR="$(mktemp -d)"

# TODO: Disable hard errors until the docs site is accessible (network problems)
EXITCODE=0
trap "EXITCODE=1" ERR
set +e

rapids-logger "Build CPP docs"
pushd cpp/doxygen
aws s3 cp s3://rapidsai-docs/librmm/html/${RAPIDS_VERSION_NUMBER}/rmm.tag . || echo "Failed to download rmm Doxygen tag"
Expand Down Expand Up @@ -66,4 +71,11 @@ if [[ "${RAPIDS_BUILD_TYPE}" != "pull-request" ]]; then
fi
popd

rapids-upload-docs
if [[ "${EXITCODE}" == "0" ]]; then
rapids-upload-docs
else
rapids-logger "Docs script had errors resulting in exit code $EXITCODE"
fi

# TODO: Disable hard errors until the docs site is accessible (network problems)
exit 0
7 changes: 5 additions & 2 deletions python/cudf/cudf/core/column/column.py
Original file line number Diff line number Diff line change
Expand Up @@ -975,9 +975,12 @@ def astype(self, dtype: Dtype, copy: bool = False) -> ColumnBase:
# TODO: Figure out why `cudf.dtype("category")`
# astype's different than just the string
return col.as_categorical_column(dtype)
elif dtype == "interval" and isinstance(
self.dtype, cudf.IntervalDtype
elif (
isinstance(dtype, str)
and dtype == "interval"
and isinstance(self.dtype, cudf.IntervalDtype)
):
# astype("interval") (the string only) should no-op
return col
was_object = dtype == object or dtype == np.dtype(object)
dtype = cudf.dtype(dtype)
Expand Down

0 comments on commit c794ce4

Please sign in to comment.