Skip to content

Commit

Permalink
change ValueError to NotImplementedError
Browse files Browse the repository at this point in the history
  • Loading branch information
davidwendt committed Feb 8, 2022
1 parent 0fb1626 commit d148dcd
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion python/cudf/cudf/core/column/string.py
Expand Up @@ -3469,7 +3469,9 @@ def findall(
flags = pat.flags & ~re.U
pat = pat.pattern
if not _is_supported_regex_flags(flags):
raise ValueError("invalid `flags` parameter value")
raise NotImplementedError(
"unsupported value for `flags` parameter"
)

data, index = libstrings.findall(self._column, pat, flags)
return self._return_or_inplace(
Expand Down

0 comments on commit d148dcd

Please sign in to comment.