Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Debug build of libcudf fails with kvikio headers #10703

Closed
davidwendt opened this issue Apr 21, 2022 · 3 comments · Fixed by rapidsai/kvikio#60
Closed

[BUG] Debug build of libcudf fails with kvikio headers #10703

davidwendt opened this issue Apr 21, 2022 · 3 comments · Fixed by rapidsai/kvikio#60
Labels
bug Something isn't working cuIO cuIO issue
Projects
v22.06 Release Bug Squashing

Comments

@davidwendt
Copy link
Contributor

Changes from PR #10593 cause the libcudf Debug build to fail with the following errors.

20-114D [229+48+134=410] Building CXX object CMakeFiles/cudf.dir/src/io/utilities/data_sink.cpp.o
FAILED: CMakeFiles/cudf.dir/src/io/utilities/data_sink.cpp.o 
/usr/local/bin/g++ -DCUDF_VERSION=22.06.00 -DCUFILE_FOUND -DJITIFY_PRINT_LOG=0 -DJITIFY_USE_CACHE -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_INFO -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_CUDA -DTHRUST_HOST_SYSTEM=THRUST_HOST_SYSTEM_CPP -Dcudf_EXPORTS -I/cudf/cpp/build/_deps/dlpack-src/include -I/cudf/cpp/build/_deps/jitify-src -I/cudf/cpp/include -I/cudf/cpp/build/include -I/cudf/cpp/src -I/conda/envs/rapids/include/rapids/libcudacxx -I/cudf/cpp/build/_deps/thrust-src -I/cudf/cpp/build/_deps/thrust-src/dependencies/cub -I/cudf/cpp/build/_deps/nvcomp-src/include -I/cudf/cpp/build/_deps/kvikio-src/cpp/include -isystem /conda/envs/rapids/include -isystem /usr/local/cuda/include -fdiagnostics-color=always -g -fPIC -Wall -Werror -Wno-unknown-pragmas -Wno-error=deprecated-declarations -Wno-deprecated-declarations -pthread -std=gnu++17 -MD -MT CMakeFiles/cudf.dir/src/io/utilities/data_sink.cpp.o -MF CMakeFiles/cudf.dir/src/io/utilities/data_sink.cpp.o.d -o CMakeFiles/cudf.dir/src/io/utilities/data_sink.cpp.o -c /cudf/cpp/src/io/utilities/data_sink.cpp
In file included from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/shim/cufile.hpp:19,
                 from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/defaults.hpp:26,
                 from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/buffer.hpp:23,
                 from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/file_handle.hpp:30,
                 from /cudf/cpp/src/io/utilities/data_sink.cpp:24:
/cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/utils.hpp: In function ‘off_t kvikio::convert_size2off(std::size_t)’:
/cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/utils.hpp:39:9: error: comparison of integer expressions of different signedness: ‘std::size_t’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]
   39 |   if (x >= std::numeric_limits<off_t>::max()) {
      |       ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
20-114D [229+46+136=410] Building CXX object CMakeFiles/cudf.dir/src/io/utilities/datasource.cpp.o
FAILED: CMakeFiles/cudf.dir/src/io/utilities/datasource.cpp.o 
/usr/local/bin/g++ -DCUDF_VERSION=22.06.00 -DCUFILE_FOUND -DJITIFY_PRINT_LOG=0 -DJITIFY_USE_CACHE -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_INFO -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_CUDA -DTHRUST_HOST_SYSTEM=THRUST_HOST_SYSTEM_CPP -Dcudf_EXPORTS -I/cudf/cpp/build/_deps/dlpack-src/include -I/cudf/cpp/build/_deps/jitify-src -I/cudf/cpp/include -I/cudf/cpp/build/include -I/cudf/cpp/src -I/conda/envs/rapids/include/rapids/libcudacxx -I/cudf/cpp/build/_deps/thrust-src -I/cudf/cpp/build/_deps/thrust-src/dependencies/cub -I/cudf/cpp/build/_deps/nvcomp-src/include -I/cudf/cpp/build/_deps/kvikio-src/cpp/include -isystem /conda/envs/rapids/include -isystem /usr/local/cuda/include -fdiagnostics-color=always -g -fPIC -Wall -Werror -Wno-unknown-pragmas -Wno-error=deprecated-declarations -Wno-deprecated-declarations -pthread -std=gnu++17 -MD -MT CMakeFiles/cudf.dir/src/io/utilities/datasource.cpp.o -MF CMakeFiles/cudf.dir/src/io/utilities/datasource.cpp.o.d -o CMakeFiles/cudf.dir/src/io/utilities/datasource.cpp.o -c /cudf/cpp/src/io/utilities/datasource.cpp
In file included from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/shim/cufile.hpp:19,
                 from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/defaults.hpp:26,
                 from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/buffer.hpp:23,
                 from /cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/file_handle.hpp:30,
                 from /cudf/cpp/src/io/utilities/datasource.cpp:23:
/cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/utils.hpp: In function ‘off_t kvikio::convert_size2off(std::size_t)’:
/cudf/cpp/build/_deps/kvikio-src/cpp/include/kvikio/utils.hpp:39:9: error: comparison of integer expressions of different signedness: ‘std::size_t’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]
   39 |   if (x >= std::numeric_limits<off_t>::max()) {
      |       ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
@davidwendt davidwendt added bug Something isn't working Needs Triage Need team to review and classify labels Apr 21, 2022
@davidwendt davidwendt added this to Issue-Needs prioritizing in v22.06 Release via automation Apr 21, 2022
@github-actions github-actions bot added this to Needs prioritizing in Bug Squashing Apr 21, 2022
@davidwendt
Copy link
Contributor Author

@madsbk @vuule

@davidwendt davidwendt added the cuIO cuIO issue label Apr 21, 2022
@madsbk
Copy link
Member

madsbk commented Apr 21, 2022

Will fix, first thing tomorrow!

This was referenced Apr 22, 2022
Merged
Closed
Bug Squashing automation moved this from Needs prioritizing to Closed Apr 22, 2022
v22.06 Release automation moved this from Issue-Needs prioritizing to Done Apr 22, 2022
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this issue Apr 22, 2022
@madsbk
convert_size2off(): fix different signedness (#60)
beb0d1c 
Fixes rapidsai/cudf#10703

Also, adding `-Werror` to the compilation of the C++ example

Authors:
  - Mads R. B. Kristensen (https://github.com/madsbk)

Approvers:
  - Benjamin Zaitlen (https://github.com/quasiben)

URL: #60
@madsbk
Copy link
Member

madsbk commented Apr 22, 2022

@davidwendt please reopen, if rapidsai/kvikio#60 didn't fix the issue.

@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cuIO cuIO issue
Projects
No open projects
Bug Squashing
Closed
v22.06 Release
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

convert_size2off(): fix different signedness madsbk/kvikio
3 participants
@madsbk @bdice @davidwendt