-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] cudf.read_csv
and internal ioutils
should indicate how **kwargs
are used.
#10823
Comments
Thanks for the ping @bdice. iirc the origin for However since then Pandas has also adopted |
Right - We can remove |
This issue has been labeled |
This issue has been labeled |
Fixes: #11683, #10823 This PR: - [x] Removes `kwargs` in CSV reader & writer such that users get clear errors when they misspell a parameter. - [x] Re-orders `read_csv` & `to_csv` parameters which will now match to pandas. The diff is actually adding `storage_options` to `read_csv` & `to_csv` after removing `kwargs`, and the rest of it all re-ordering appropriately. Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Ashwin Srinath (https://github.com/shwina) - Vukasin Milovanovic (https://github.com/vuule) URL: #11762
Resolved by #11762 |
Report incorrect documentation
Location of incorrect documentation
https://docs.rapids.ai/api/cudf/nightly/api_docs/api/cudf.read_csv.html#cudf.read_csv
Describe the problems or issues found in the documentation
The
cudf.read_csv
function accepts**kwargs
but it does not indicate how they are used. We should avoid accepting arbitrary keyword arguments because it makes it difficult for users to recognize when unsupported keywords are passed. For example, this silently ignores the user's intention (which might be to useusecols
anddtype
instead ofcols
anddtypes
):These
**kwargs
are passed on in a couple places but I'm not familiar with their intended use:cudf/python/cudf/cudf/utils/ioutils.py
Line 1145 in 4539e5e
cudf/python/cudf/cudf/utils/ioutils.py
Line 1331 in 4539e5e
Suggested fix for documentation
Investigate
read_csv
and related utility functions to determine how**kwargs
are used, and document them accordingly.If possible, I would prefer to remove
**kwargs
from the I/O functions in favor of named keyword(s) that can serve the same purpose.Tagging @rjzamora @ayushdg who may have insight from editing this code in the past.
The text was updated successfully, but these errors were encountered: