Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Change Column.sort_by_values to Column.sort_values. #13391

Closed
bdice opened this issue May 19, 2023 · 0 comments · Fixed by #13419
Closed

[FEA] Change Column.sort_by_values to Column.sort_values. #13391

bdice opened this issue May 19, 2023 · 0 comments · Fixed by #13419
Assignees
@bdice
Labels
cuDF (Python) Affects Python cuDF API. feature request New feature or request Performance Performance related issue

Comments

@bdice
Copy link
Contributor

bdice commented May 19, 2023

Is your feature request related to a problem? Please describe.

cuDF Python has a method Column.sort_by_values that returns the sorted values and their indices. Unfortunately we never use both the values and the indices, only one or the other. We also have Column.argsort which returns just the indices.

Describe the solution you'd like
I propose we change Column.sort_by_values to Column.sort_values and drop the indices. This reduces the complexity of the implementation. If users need both values and indices, they can compute the argsort and then use it as a gather map to take.
@bdice bdice added feature request New feature or request cuDF (Python) Affects Python cuDF API. labels May 19, 2023
@bdice bdice self-assigned this May 19, 2023
@bdice bdice mentioned this issue May 23, 2023
Merged
3 tasks
@bdice bdice added the Performance Performance related issue label Jun 6, 2023
rapids-bot bot pushed a commit that referenced this issue Jun 14, 2023
@bdice
Refactor sort_by_values to sort_values, drop indices from return valu…
ceeb392 
…es. (#13419)

This PR closes #13391.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)

URL: #13419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdice bdice

Labels
cuDF (Python) Affects Python cuDF API. feature request New feature or request Performance Performance related issue
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor sort_by_values to sort_values, drop indices from return values. bdice/cudf
1 participant
@bdice