Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] TableTest.testChunkedPackTwoPasses is breaking CI #15209

Closed
abellina opened this issue Mar 1, 2024 · 6 comments
Closed

[BUG] TableTest.testChunkedPackTwoPasses is breaking CI #15209

abellina opened this issue Mar 1, 2024 · 6 comments
Assignees
@abellina
Labels
bug Something isn't working Java Affects Java cuDF API.

Comments

@abellina
Copy link
Contributor

abellina commented Mar 1, 2024

We have gotten reports of TableTest.testChunkedPackTwoPasses breaking CI and we need to investigate what exactly is going on. @nvdbaranec did work to isolate the issue and has gotten it down to this test by itself breaking, if it's changed slightly to initialize part of the column that is getting chunked packed.

Our plan is to disable it for now and work on a permanent fix. The test has been running for a while and it is unclear why it's failing now.
@abellina abellina added bug Something isn't working Java Affects Java cuDF API. labels Mar 1, 2024
@abellina abellina self-assigned this Mar 1, 2024
This was referenced Mar 1, 2024
Merged
Closed
@abellina
Copy link
Contributor Author

abellina commented Mar 1, 2024

The bug has been found, it's only in the tests, I'll put up a separate patch to bring back the test with the fix.

@davidwendt
Copy link
Contributor

Should you mark #15210 as do-not-merge then? Or maybe just close it.

@abellina
Copy link
Contributor Author

abellina commented Mar 1, 2024

Should you mark #15210 as do-not-merge then? Or maybe just close it.

I didn’t want to have everyone wait for CI, so I was going to let that merge and post a fix Monday. Sorry that my comment wasn’t clear.

@ttnghia
Copy link
Contributor

ttnghia commented Mar 2, 2024

The PR #15210 couldn't be merged anyway, before Monday. So I think it is no longer needed, you should better close it and post your fix instead.

@bdice
Copy link
Contributor

bdice commented Mar 4, 2024 •
edited

I requested an admin-merge for #15210 to unblock CI for all of cudf. We can get a fix in after CI is unblocked.

@abellina
Copy link
Contributor Author

abellina commented Mar 5, 2024

This was finally fixed by: #15220.

@abellina abellina closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abellina abellina

Labels
bug Something isn't working Java Affects Java cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@abellina @bdice @ttnghia @davidwendt