Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] (De-)Serialization Review #2616

Closed
quasiben opened this issue Aug 16, 2019 · 1 comment
Closed

[BUG] (De-)Serialization Review #2616

quasiben opened this issue Aug 16, 2019 · 1 comment
Labels
bug Something isn't working dask Dask issue Python Affects Python cuDF API.

Comments

@quasiben
Copy link
Member

In submitting a PR fixing index serialization: #2610, @kkraus14 found additional

@quasiben Another potential serialization / deserialization issue: https://github.com/rapidsai/cudf/blob/branch-0.10/python/cudf/cudf/groupby/groupby.py#L69
There's a Series which is backed by device memory underneath the groupby object.

@quasiben Another potential serialization / deserialization issue: https://github.com/rapidsai/cudf/blob/branch-0.10/python/cudf/cudf/groupby/groupby.py#L69
There's a Series which is backed by device memory underneath the groupby object.
This one too: https://github.com/rapidsai/cudf/blob/branch-0.10/python/cudf/cudf/groupby/groupby.py#L140

We should ensure the correctness of the serialization scheme by adding additional tests to test_serialize.py. This could be done by adding more "flavors" of cudf objects, confirming data is GPU backed after serialization, confirming data is in the frames of the serialized return and not the header

@quasiben quasiben added bug Something isn't working Needs Triage Need team to review and classify labels Aug 16, 2019
@kkraus14 kkraus14 added Python Affects Python cuDF API. dask Dask issue and removed Needs Triage Need team to review and classify labels Aug 16, 2019
@quasiben
Copy link
Member Author

I'm going to close this. @shwina and I have been through the code a number of time now and #2619 address this issue as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dask Dask issue Python Affects Python cuDF API.
Projects
None yet
Development

No branches or pull requests

2 participants