Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .list.astype() to cast list leaves to specified dtype #10693

Merged
merged 4 commits into from Apr 21, 2022

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Apr 20, 2022

Closes #10687.

@shwina shwina requested a review from a team as a code owner April 20, 2022 18:26
@github-actions github-actions bot added the cuDF (Python) Affects Python cuDF API. label Apr 20, 2022
@shwina shwina added feature request New feature or request non-breaking Non-breaking change labels Apr 20, 2022
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #10693 (abc1dc8) into branch-22.06 (65b1cbd) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head abc1dc8 differs from pull request most recent head 53ca862. Consider uploading reports for the commit 53ca862 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10693      +/-   ##
================================================
+ Coverage         86.35%   86.38%   +0.03%     
================================================
  Files               142      142              
  Lines             22335    22339       +4     
================================================
+ Hits              19287    19298      +11     
+ Misses             3048     3041       -7     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/lists.py 92.91% <100.00%> (+1.39%) ⬆️
python/cudf/cudf/core/column/string.py 89.22% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.64% <0.00%> (+0.23%) ⬆️
python/cudf/cudf/core/column/numerical.py 96.17% <0.00%> (+0.29%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b1cbd...53ca862. Read the comment docs.

Copy link
Contributor

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small query

python/cudf/cudf/tests/test_list.py Show resolved Hide resolved
@shwina shwina added this to PR-WIP in v22.06 Release via automation Apr 21, 2022
@shwina
Copy link
Contributor Author

shwina commented Apr 21, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 070aef1 into rapidsai:branch-22.06 Apr 21, 2022
v22.06 Release automation moved this from PR-WIP to Done Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuDF (Python) Affects Python cuDF API. feature request New feature or request non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[FEA] Support list element casting from strings to numeric types
2 participants