Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickly error out when trying to build with unsupported nvcc versions #11297

Conversation

robertmaynard
Copy link
Contributor

Instead of waiting to compilation time to get a confusing error about int128 support. Quickly terminate at CMake time when we detect an insufficient nvcc version.

@robertmaynard robertmaynard added feature request New feature or request 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jul 19, 2022
@robertmaynard robertmaynard added this to PR-WIP in v22.08 Release via automation Jul 19, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner July 19, 2022 13:08
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@2dc5c3f). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2500376 differs from pull request most recent head b36c323. Consider uploading reports for the commit b36c323 to get more accurate results

@@               Coverage Diff               @@
##             branch-22.10   #11297   +/-   ##
===============================================
  Coverage                ?   86.47%           
===============================================
  Files                   ?      144           
  Lines                   ?    22856           
  Branches                ?        0           
===============================================
  Hits                    ?    19765           
  Misses                  ?     3091           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc5c3f...b36c323. Read the comment docs.

v22.08 Release automation moved this from PR-WIP to PR-Reviewer approved Jul 20, 2022
@bdice bdice requested review from vyasr and jrhemstad July 28, 2022 03:29
@robertmaynard robertmaynard removed this from PR-Reviewer approved in v22.08 Release Jul 28, 2022
@robertmaynard robertmaynard added this to PR-WIP in v22.10 Release via automation Jul 28, 2022
v22.10 Release automation moved this from PR-WIP to PR-Reviewer approved Aug 2, 2022
@robertmaynard robertmaynard changed the base branch from branch-22.08 to branch-22.10 August 2, 2022 13:46
@robertmaynard robertmaynard force-pushed the fea/nice_error_message_on_older_ctk_versions branch from 30e3eaa to b36c323 Compare August 2, 2022 15:47
@vyasr
Copy link
Contributor

vyasr commented Aug 2, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 039622f into rapidsai:branch-22.10 Aug 2, 2022
v22.10 Release automation moved this from PR-Reviewer approved to Done Aug 2, 2022
@robertmaynard robertmaynard deleted the fea/nice_error_message_on_older_ctk_versions branch August 10, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants