Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cmake to the build section. #11376

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jul 28, 2022

Description

As a CLI tool CMake belongs in the build section and shouldn't need to be present in the host requirements.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 28, 2022
@vyasr vyasr self-assigned this Jul 28, 2022
@vyasr vyasr requested a review from a team as a code owner July 28, 2022 00:45
@vyasr vyasr added this to PR-WIP in v22.10 Release via automation Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@c6563a1). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.10   #11376   +/-   ##
===============================================
  Coverage                ?   86.43%           
===============================================
  Files                   ?      143           
  Lines                   ?    22777           
  Branches                ?        0           
===============================================
  Hits                    ?    19687           
  Misses                  ?     3090           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6563a1...34b93e3. Read the comment docs.

v22.10 Release automation moved this from PR-WIP to PR-Reviewer approved Aug 1, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Aug 1, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 797215b into rapidsai:branch-22.10 Aug 1, 2022
v22.10 Release automation moved this from PR-Reviewer approved to Done Aug 1, 2022
@vyasr vyasr deleted the fix/conda_meta_cmake branch August 2, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants