Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HASH_SERIAL_MURMUR3 / serial32BitMurmurHash3 #11383

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Remove HASH_SERIAL_MURMUR3 / serial32BitMurmurHash3 #11383

merged 1 commit into from
Aug 1, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jul 28, 2022 •
edited
Loading

Description

This PR closes #11296. While implementing Spark list hashing in #11292, I noticed that HASH_SERIAL_MURMUR3 does not appear to be used except in tests. It is not exposed in Python. While it is exposed in the JNI bindings, it is not used by spark-rapids. I discussed this with @rwlee and it seems that this feature was added only for parallel design with the Spark serial hash implementation in #6781, which is superseded by #11292. We do not need to keep this vestigial feature.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice self-assigned this Jul 28, 2022
@bdice bdice changed the base branch from branch-22.08 to branch-22.10 July 28, 2022 06:44
@github-actions github-actions bot added Java Affects Java cuDF API. Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Jul 28, 2022
@bdice bdice added tech debt improvement Improvement / enhancement to an existing function breaking Breaking change libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. Java Affects Java cuDF API. and removed libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. Java Affects Java cuDF API. labels Jul 28, 2022
@bdice bdice added this to PR-WIP in v22.10 Release via automation Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@5170edb). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 198732e differs from pull request most recent head 3298915. Consider uploading reports for the commit 3298915 to get more accurate results

@@               Coverage Diff               @@
##             branch-22.10   #11383   +/-   ##
===============================================
  Coverage                ?   86.43%           
===============================================
  Files                   ?      144           
  Lines                   ?    22808           
  Branches                ?        0           
===============================================
  Hits                    ?    19713           
  Misses                  ?     3095           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5170edb...3298915. Read the comment docs.

@bdice
Copy link
Contributor Author

bdice commented Jul 28, 2022

rerun tests

@bdice bdice marked this pull request as ready for review July 28, 2022 17:08
@bdice bdice requested review from a team as code owners July 28, 2022 17:08
brandon-b-miller
brandon-b-miller approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cython approval

davidwendt
davidwendt approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Gotta like negative lines of code.

v22.10 Release automation moved this from PR-WIP to PR-Reviewer approved Aug 1, 2022
@bdice
Copy link
Contributor Author

bdice commented Aug 1, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1d4aa4a into rapidsai:branch-22.10 Aug 1, 2022
v22.10 Release automation moved this from PR-Reviewer approved to Done Aug 1, 2022
@bdice bdice mentioned this pull request Aug 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@jlowe jlowe jlowe approved these changes

@davidwendt davidwendt davidwendt approved these changes

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@bdice bdice

Labels
breaking Breaking change improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
No open projects
v22.10 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove HASH_SERIAL_MURMUR3 / serial32BitMurmurHash3
5 participants
@bdice @robertmaynard @jlowe @davidwendt @brandon-b-miller