Extract Dremel encoding code from Parquet #11461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many iterations already happened. I just realized late that I should commit
sliced no longer works
early return and remove unnecessary statements
vyasr
added
3 - Ready for Review
bdice
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Approving this as it is a move and slight refactor to namespaces. I have already reviewed this code in #11129 and identified some areas for improvement. We need to keep momentum while avoiding conflicts between the lexicographic comparator work and Parquet work.
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #11461 +/- ##
===============================================
Coverage ? 86.47%
===============================================
Files ? 144
Lines ? 22856
Branches ? 0
===============================================
Hits ? 19765
Misses ? 3091
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
raydouglass
approved these changes
Aug 4, 2022
vuule
approved these changes
Aug 4, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the Dremel encoding logic from Parquet-specific files and places it into a separate set of files for consumption by non-Parquet code. This PR also includes a minor rename of
utilities/column.hpp->utilities/linked_column.hppto more accurately reflect the contents of that file.These changes were split out from #11129 to minimize future conflicts with Parquet development (which is very active at present) and to allow further refactoring and other improvements on this Dremel code to proceed independently of the list lexicographic comparator.
Checklist