Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reverse binary operators acting on a host value and cudf.Scalar #11512

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Fix reverse binary operators acting on a host value and cudf.Scalar #11512

merged 3 commits into from
Aug 11, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 11, 2022 •
edited
Loading

Description

This PR resolves #11225. It fixes binary operator dispatch for reverse ops like __radd__ acting on host scalars and cudf.Scalar objects in expressions like 1 + cudf.Scalar(3), which previously threw an error.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice self-assigned this Aug 11, 2022
@bdice bdice requested a review from a team as a code owner August 11, 2022 03:21
@bdice bdice requested review from vyasr and mroeschke August 11, 2022 03:21
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 11, 2022
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Aug 11, 2022
@bdice bdice added this to PR-WIP in v22.10 Release via automation Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@9257549). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.10   #11512   +/-   ##
===============================================
  Coverage                ?   86.48%           
===============================================
  Files                   ?      144           
  Lines                   ?    22850           
  Branches                ?        0           
===============================================
  Hits                    ?    19761           
  Misses                  ?     3089           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

brandon-b-miller
brandon-b-miller approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bdice !

v22.10 Release automation moved this from PR-WIP to PR-Reviewer approved Aug 11, 2022
@bdice
Copy link
Contributor Author

bdice commented Aug 11, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 80bce29 into rapidsai:branch-22.10 Aug 11, 2022
v22.10 Release automation moved this from PR-Reviewer approved to Done Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@bdice bdice

Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
No open projects
v22.10 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Reverse binary ops between cudf.Scalar and base types not working.
3 participants
@bdice @mroeschke @brandon-b-miller