Maintain the index name after .loc
#11677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwina
commented
Sep 9, 2022
| @@ -286,6 +286,7 @@ def test_dataframe_loc(scalar, step): | |||
| "d": np.random.random(size).astype(np.float64), | |||
| } | |||
| ) | |||
| pdf.index.name = "index" | |||
There was a problem hiding this comment.
.iloc behaved correctly before the changes in this PR. Just adding this here for completeness.
galipremsagar
approved these changes
Sep 9, 2022
|
rerun tests |
galipremsagar
added
the
5 - Ready to Merge
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #11677 +/- ##
===============================================
Coverage ? 86.41%
===============================================
Files ? 145
Lines ? 23005
Branches ? 0
===============================================
Hits ? 19880
Misses ? 3125
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #11664
Checklist