Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_thrust.cmake format at patch command #11715

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Places the PATCH_COMMAND on it's own line separate from the GIT_SHALLOW command line.
Recently got a style-check error on get_thrust.cmake
https://gpuci.gpuopenanalytics.com/blue/organizations/jenkins/rapidsai%2Fgpuci%2Fcudf%2Fprb%2Fcudf-style/detail/cudf-style/28876/pipeline
The style-check tool was used to fix this.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Sep 19, 2022
@davidwendt davidwendt self-assigned this Sep 19, 2022
@davidwendt davidwendt requested a review from a team as a code owner September 19, 2022 14:06
@davidwendt davidwendt added this to PR-WIP in v22.10 Release via automation Sep 19, 2022
@github-actions github-actions bot added the CMake CMake build issue label Sep 19, 2022
v22.10 Release automation moved this from PR-WIP to PR-Reviewer approved Sep 19, 2022
@robertmaynard
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 68746ae into rapidsai:branch-22.10 Sep 19, 2022
v22.10 Release automation moved this from PR-Reviewer approved to Done Sep 19, 2022
@davidwendt davidwendt deleted the get-thrust-cmake-fix-format branch September 19, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants