Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type of Index.isna & Index.notna #11769

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

galipremsagar
Copy link
Contributor

Description

This PR fixes: #11159 by returning correct object type for the result of isna & notna in Index.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer breaking Breaking change labels Sep 26, 2022
@galipremsagar galipremsagar self-assigned this Sep 26, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner September 26, 2022 17:53
@galipremsagar galipremsagar added this to PR-WIP in v22.10 Release via automation Sep 26, 2022
@galipremsagar galipremsagar moved this from PR-WIP to PR-Needs review in v22.10 Release Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@cd60462). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head d04f4f0 differs from pull request most recent head db6a913. Consider uploading reports for the commit db6a913 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10   #11769   +/-   ##
===============================================
  Coverage                ?   87.52%           
===============================================
  Files                   ?      133           
  Lines                   ?    21787           
  Branches                ?        0           
===============================================
  Hits                    ?    19069           
  Misses                  ?     2718           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

v22.10 Release automation moved this from PR-Needs review to PR-Reviewer approved Sep 26, 2022
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Sep 26, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e64c2da into rapidsai:branch-22.10 Sep 26, 2022
v22.10 Release automation moved this from PR-Reviewer approved to Done Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change bug Something isn't working Python Affects Python cuDF API.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[BUG] Index.isna should return an array, not an Index
2 participants