Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guide-to-udfs notebook #11861

Merged

Conversation

brandon-b-miller
Copy link
Contributor

Updates guide-to-udf notebook to run string udf related cells conditional on the library being present and enabled.

@brandon-b-miller brandon-b-miller added doc Documentation Python Affects Python cuDF API. non-breaking Non-breaking change labels Oct 4, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot removed the Python Affects Python cuDF API. label Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 87.52% // Head: 87.52% // No change to project coverage 👍

Coverage data is based on head (ff7dfff) compared to base (dfd3d89).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-22.10   #11861   +/-   ##
=============================================
  Coverage         87.52%   87.52%           
=============================================
  Files               133      133           
  Lines             21807    21807           
=============================================
  Hits              19087    19087           
  Misses             2720     2720           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -20,6 +20,16 @@
"import numpy as np"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #1.    strings_enabled = cudf.core.udf._STRING_UDFS_ENABLED

- The variable name strings_enabled feels misleading (it indicates general support for strings, rather than just for UDFs)

- Can we move this closer to where it's actually used? It's fine if we compute it redundantly for both the Series and DataFrame sections.


Reply via ReviewNB

@jolorunyomi jolorunyomi merged commit a9e7471 into rapidsai:branch-22.10 Oct 5, 2022
@galipremsagar galipremsagar added this to PR-WIP in v22.10 Release via automation Oct 5, 2022
@galipremsagar galipremsagar moved this from PR-WIP to Done in v22.10 Release Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants