[REVIEW] Handle ptx file paths during strings_udf import

[galipremsagar]

Description

strings_udf is currently throwing an error on import when source compiled with only one gpu arch:

----> 1 import cudf

File /nvme/0/pgali/envs/cudfdev/lib/python3.9/site-packages/cudf/__init__.py:20
     14 from cudf.api.extensions import (
     15     register_dataframe_accessor,
     16     register_index_accessor,
     17     register_series_accessor,
     18 )
     19 from cudf.api.types import dtype
---> 20 from cudf.core.algorithms import factorize
     21 from cudf.core.cut import cut
     22 from cudf.core.dataframe import DataFrame, from_dataframe, from_pandas, merge

.
.
.
File /nvme/0/pgali/envs/cudfdev/lib/python3.9/site-packages/cudf/core/indexed_frame.py:60
     58 from cudf.core.multiindex import MultiIndex
     59 from cudf.core.resample import _Resampler
---> 60 from cudf.core.udf.utils import (
     61     _compile_or_get,
     62     _get_input_args_from_frame,
     63     _post_process_output_col,
     64     _return_arr_from_dtype,
     65 )
     66 from cudf.utils import docutils
     67 from cudf.utils.utils import _cudf_nvtx_annotate

File /nvme/0/pgali/envs/cudfdev/lib/python3.9/site-packages/cudf/core/udf/__init__.py:27
     25 _STRING_UDFS_ENABLED = False
     26 try:
---> 27     import strings_udf
     29     if strings_udf.ENABLED:
     30         from . import strings_typing  # isort: skip

File /nvme/0/pgali/envs/cudfdev/lib/python3.9/site-packages/strings_udf/__init__.py:66
     62 import pdb;pdb.set_trace()
     63 sms = [
     64     os.path.basename(f).rstrip(".ptx").lstrip("shim_") for f in files
     65 ]
---> 66 selected_sm = max(sm for sm in sms if sm < cc)
     67 ptxpath = os.path.join(
     68     os.path.dirname(__file__), f"shim_{selected_sm}.ptx"
     69 )
     71 if driver_version >= compiler_from_ptx_file(ptxpath):

ValueError: max() arg is an empty sequence

This PR fixes the above issue and also handles shim_sm-real.ptx and shim_sm.ptx files appropriately.

Checklist

• I am familiar with the Contributing Guidelines.
• The documentation is up to date with these changes.

[codecov]

Codecov Report

Base: 87.52% // Head: 87.51% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (d321b0e) compared to base (dfd3d89).
Patch coverage: 75.00% of modified lines in pull request are covered.

❗ Current head d321b0e differs from pull request most recent head 3011d96. Consider uploading reports for the commit 3011d96 to get more accurate results

Additional details and impacted files

@@               Coverage Diff                @@
##           branch-22.10   #11862      +/-   ##
================================================
- Coverage         87.52%   87.51%   -0.02%     
================================================
  Files               133      133              
  Lines             21807    21826      +19     
================================================
+ Hits              19087    19100      +13     
- Misses             2720     2726       +6     

Impacted Files	Coverage Δ
python/strings_udf/strings_udf/__init__.py	86.27% <75.00%> (-10.61%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[robertmaynard]

this can't be a number. SM's aren't all numeric values any more

[robertmaynard]

To be clear the dev.compute_capability value will always be an integer. ( 75, 80, 90, ... ). But going forward we will see code gen with values like 90a which means they hold sm90 only instructions that can't be used by newer archs

[robertmaynard]

You need to strip -real and -virtual

[robertmaynard]

It might be best to update the CMake side to transform CMAKE_CUDA_ARCHITECTURES to be a unique set of architectures without any -real and -virtual postfixes so the python loading side has a 1 to 1 mapping.

[robertmaynard]

Looks amazing, Thanks!

[galipremsagar]

rerun tests