Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in dataframe.py #12369

Merged
merged 21 commits into from
Dec 19, 2022
Merged

Fix warnings in dataframe.py #12369

merged 21 commits into from
Dec 19, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 13, 2022

Description

Contributes to #9999 and #10363.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr
Fix uses of append.
69823a5
@vyasr
Fix binop tests that involve deprecated indexing from pandas.
9a4c9e8
@vyasr
Find cases where pandas warns on concat different column dtypes.
37500ea
@vyasr
Clean up conditional logic.
d6f8ba5
@vyasr
Remove explicit usage of bool.
fef1030
@vyasr
Change to passing numeric_only in test_quantile.
610ae19
@vyasr
Stop relying on default dtype.
61f61c2
@vyasr
Stop relying on default dtype in more places.
575b95a
@vyasr
Handle warnings around numeric_only in rowwise operations.
1fbe45a
@vyasr
Ignore reindexing warnings from pandas that we'll have to react to in…
f4d37b3 
… 2.0 when the functionality is removed.
@vyasr
Catch cupy warnings from all nan rows.
0d9d9b8
@vyasr
Specify float column to avoid undesired object column in rowwise op.
20f2616
@vyasr
Mask warning for min/max involving numeric and datetime columns in ro…
cc8c91b 
…wwise ops.
@vyasr
Also catch FutureWarnings from pandas for dropping datetime columns i…
84caede 
…n mixed datetime/numeric reductions.
@vyasr
Catch our warning for passing deep to copy.
114088d
@vyasr
Specify dtype instead of relying on pandas default.
2bed438
@vyasr
Mask singular covariance matrix warnings.
a98dffc
@vyasr
Modify inputs to avoid singular groups.
3da6409
@vyasr
One more set of reindexing warnings.
99c4ba4
@vyasr vyasr added 3 - Ready for Review Ready for review by team tests Unit testing for project code quality Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 13, 2022
@vyasr vyasr requested a review from a team as a code owner December 13, 2022 02:24
@vyasr vyasr self-assigned this Dec 13, 2022
@vyasr vyasr added this to PR-WIP in v23.02 Release via automation Dec 13, 2022
@vyasr vyasr requested a review from shwina December 13, 2022 02:24
@vyasr vyasr requested a review from isVoid December 13, 2022 02:24
@vyasr
Copy link
Contributor Author

vyasr commented Dec 13, 2022

I would like to draw reviewer attention to my comment about pandas behavior. I am not sure why this behavior makes sense, or if we should be pushing to get it changed.

@vyasr
Copy link
Contributor Author

vyasr commented Dec 13, 2022

rerun tests

@codecov
Copy link

codecov bot commented Dec 15, 2022 •
edited
Loading

Codecov Report

Base: 86.58% // Head: 85.76% // Decreases project coverage by -0.81% ⚠️

Coverage data is based on head (a0ff643) compared to base (b6dccb3).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-23.02   #12369      +/-   ##
================================================
- Coverage         86.58%   85.76%   -0.82%     
================================================
  Files               155      155              
  Lines             24368    24798     +430     
================================================
+ Hits              21098    21269     +171     
- Misses             3270     3529     +259
Impacted Files Coverage Δ
python/cudf/cudf/_version.py 1.41% <0.00%> (-98.59%) ⬇️
python/cudf/cudf/core/buffer/spill_manager.py 74.37% <0.00%> (-5.63%) ⬇️
python/cudf/cudf/utils/dtypes.py 77.77% <0.00%> (-1.69%) ⬇️
python/cudf/cudf/options.py 86.11% <0.00%> (-1.59%) ⬇️
python/cudf/cudf/core/single_column_frame.py 94.30% <0.00%> (-1.27%) ⬇️
python/dask_cudf/dask_cudf/io/parquet.py 91.81% <0.00%> (-0.59%) ⬇️
python/cudf/cudf/core/multiindex.py 91.66% <0.00%> (-0.51%) ⬇️
python/cudf/cudf/core/algorithms.py 90.00% <0.00%> (-0.48%) ⬇️
python/cudf/cudf/core/dataframe.py 93.50% <0.00%> (-0.09%) ⬇️
python/cudf/cudf/core/join/_join_helpers.py 98.52% <0.00%> (-0.07%) ⬇️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasr vyasr added 3 - Ready for Review Ready for review by team and removed 3 - Ready for Review Ready for review by team labels Dec 16, 2022
@vyasr vyasr mentioned this pull request Dec 17, 2022
Merged
3 tasks
mroeschke
mroeschke approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pandas compat changes LGTM

v23.02 Release automation moved this from PR-WIP to PR-Reviewer approved Dec 19, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Dec 19, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 89c03af into rapidsai:branch-23.02 Dec 19, 2022
v23.02 Release automation moved this from PR-Reviewer approved to Done Dec 19, 2022
@vyasr vyasr deleted the fix/dataframe_warnings branch December 19, 2022 20:36
rapids-bot bot pushed a commit that referenced this pull request Dec 21, 2022
@vyasr
Fix warnings in remaining modules (#12406)
1d81fbb 
Contributes to #9999 and #10363.

When I merge these changes with #12369 I no longer see any warnings on my machine. I suspect that there will be slightly different results on different machines, so we'll see have to see how CI looks after both PRs are merged before we close #10363.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Matthew Roeschke (https://github.com/mroeschke)
  - Bradley Dice (https://github.com/bdice)

URL: #12406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@mroeschke mroeschke mroeschke approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API. tests Unit testing for project
Projects
cuDF/Dask/Numba/UCX
Archived in project
v23.02 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vyasr @shwina @mroeschke