-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise warnings as errors in the test suite #12468
Merged
rapids-bot
merged 10 commits into
rapidsai:branch-23.02
from
vyasr:feat/warnings_as_errors
Jan 5, 2023
Merged
Raise warnings as errors in the test suite #12468
rapids-bot
merged 10 commits into
rapidsai:branch-23.02
from
vyasr:feat/warnings_as_errors
Jan 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
Ready for review by team
tests
Unit testing for project
code quality
Python
Affects Python cuDF API.
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Jan 3, 2023
bdice
approved these changes
Jan 4, 2023
mroeschke
reviewed
Jan 4, 2023
Codecov ReportBase: 86.58% // Head: 85.69% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #12468 +/- ##
================================================
- Coverage 86.58% 85.69% -0.89%
================================================
Files 155 155
Lines 24368 24798 +430
================================================
+ Hits 21098 21250 +152
- Misses 3270 3548 +278
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mroeschke
approved these changes
Jan 5, 2023
/merge |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
tests
Unit testing for project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a final few warnings introduced in PRs merged after #12406 or with changes that weren't merged into #12406. More importantly, this PR updates the testing suite to always raise uncaught warnings as errors. This is a substantial change to the testing suite that will allow us to proactively react to deprecations in our dependencies, identify areas where pandas/pyarrow/some other dependency handles input data in different ways than us, etc. I've opted for the strictest possible setting, but am open to reviewer requests to be a little more lax with certain classes of warnings.
Checklist