[REVIEW] Drop DataFrame.append and Series.append
#12839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
3 - Ready for Review
galipremsagar
requested review from
bdice and
mroeschke
and removed request for
a team
mroeschke
reviewed
Feb 24, 2023
| expected = pd.concat([pdf, other_pd], sort=sort, ignore_index=ignore_index) | ||
| actual = cudf.concat([gdf, other_gd], sort=sort, ignore_index=ignore_index) | ||
|
|
||
| # In some cases, Pandas creates an empty Index([], dtype="object") for |
There was a problem hiding this comment.
Could you show a example where this happens? I think pandas would also like to return an empty RangeIndex too if the object is empty-like
There was a problem hiding this comment.
Apologies for an incorrect comment previously. So the actual issue is with how cudf & pandas represent empty columns. In case of pandas it's always an empty RangeIndex, but in cudf it's always an empty Index:
In [1]: import cudf
In [2]: import pandas as pd
In [3]: df = cudf.DataFrame()
In [4]: pdf = pd.DataFrame()
In [5]: df.columns
Out[5]: RangeIndex(start=0, stop=0, step=1)
In [6]: pdf.columns
Out[6]: Index([], dtype='object')Due to this difference, when we concat similar dataframes, pandas still returns a RangeIndex, whereas cudf will return an empty Index. Which is why we needed this special handling here for pytest.
There was a problem hiding this comment.
Okay cool thanks for the clarification!
mroeschke
approved these changes
Mar 10, 2023
shwina
approved these changes
Mar 10, 2023
galipremsagar
added
5 - Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
DataFrame.append&Series.appendto match pandas-2.0 API. Test usages are now replaced with.concatAPI calls.pytests related to these changes:
Checklist