Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Drop datetime_is_numeric parameter from describe #12890

Merged
merged 2 commits into from
Mar 8, 2023
Merged

[REVIEW] Drop datetime_is_numeric parameter from describe #12890

merged 2 commits into from
Mar 8, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR removes support for datetime_is_numeric parameter in describe.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function breaking Breaking change labels Mar 6, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner March 6, 2023 23:55
@galipremsagar galipremsagar self-assigned this Mar 6, 2023
@galipremsagar galipremsagar requested review from vyasr and skirui-source and removed request for a team March 6, 2023 23:55
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 6, 2023
@galipremsagar galipremsagar mentioned this pull request Mar 7, 2023
Closed
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Mar 8, 2023
@galipremsagar galipremsagar merged commit 5af0583 into rapidsai:pandas_2.0_feature_branch Mar 8, 2023
@galipremsagar galipremsagar mentioned this pull request Apr 20, 2023
Merged
3 tasks
galipremsagar added a commit that referenced this pull request Apr 20, 2023
@galipremsagar
Fix DataFrame.describe pytests (#13191)
31e08c9 
#12890 dropped support for `datetime_is_numeric` from `describe` API. This PR cleans-up a remaining pytest that was using this parameter.

This PR fixes 20 pytests:
```
= 464 failed, 88182 passed, 2044 skipped, 932 xfailed, 165 xpassed in 440.68s (0:07:20) =
```
On `pandas_2.0_feature_branch`:
```
= 484 failed, 88162 passed, 2044 skipped, 932 xfailed, 165 xpassed in 457.87s (0:07:37) =
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@skirui-source skirui-source Awaiting requested review from skirui-source skirui-source is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@galipremsagar @brandon-b-miller