Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Drop names, dtype in Index.copy and dtype, levels, codes in MultiIndex.copy #12898

Merged

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Mar 7, 2023

Description

This PR removes dtype in Index & MultiIndex.copy, and names in Index.copy

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function breaking Breaking change labels Mar 7, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner March 7, 2023 18:01
@galipremsagar galipremsagar self-assigned this Mar 7, 2023
@galipremsagar galipremsagar requested review from bdice and mroeschke and removed request for a team March 7, 2023 18:01
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 7, 2023
@wence-
Copy link
Contributor

wence- commented Mar 8, 2023

Looks like there are bunch of further tests that need cleanup

Attribute "name" are different
[left]:  count
[right]: None
FAILED tests/test_dataframe.py::test_value_counts[False-True-False-False-False-gdf1-subset1] - AssertionError: Series are different

@galipremsagar
Copy link
Contributor Author

Looks like there are bunch of further tests that need cleanup

Right, but those are unrelated to this PR. We are basically aiming for the final PR from the feature branch to branch-23.04 to pass.

@wence-
Copy link
Contributor

wence- commented Mar 8, 2023

Looks like there are bunch of further tests that need cleanup

Right, but those are unrelated to this PR. We are basically aiming for the final PR from the feature branch to branch-23.04 to pass.

Ah, OK. thanks.

Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question this PR title says we're dropping the names and dtype kwargs for Index.copy but I also see changes dropping levels and codes from MultiIndex.copy, is this as intended?

@galipremsagar galipremsagar changed the title [REVIEW] Drop names & dtype in Index.copy [REVIEW] Drop names, dtype in Index.copy and levels, codes in MultiIndex.copy Mar 8, 2023
@galipremsagar
Copy link
Contributor Author

galipremsagar commented Mar 8, 2023

Just one question this PR title says we're dropping the names and dtype kwargs for Index.copy but I also see changes dropping levels and codes from MultiIndex.copy, is this as intended?

Yup, it was intentional. I Updated the PR title.

@galipremsagar galipremsagar changed the title [REVIEW] Drop names, dtype in Index.copy and levels, codes in MultiIndex.copy [REVIEW] Drop names, dtype in Index.copy and dtype, levels, codes in MultiIndex.copy Mar 8, 2023
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs cuDF (Python) Reviewer labels Mar 8, 2023
@galipremsagar galipremsagar merged commit 531f52c into rapidsai:pandas_2.0_feature_branch Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants