-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nvtext::minhash function #12961
Merged
rapids-bot
merged 89 commits into
rapidsai:branch-23.06
from
davidwendt:text-minhashing
Apr 21, 2023
Merged
Add nvtext::minhash function #12961
rapids-bot
merged 89 commits into
rapidsai:branch-23.06
from
davidwendt:text-minhashing
Apr 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wence-
reviewed
Mar 20, 2023
bdice
reviewed
Apr 18, 2023
bdice
approved these changes
Apr 20, 2023
karthikeyann
approved these changes
Apr 20, 2023
ayushdg
approved these changes
Apr 20, 2023
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
CMake
CMake build issue
feature request
New feature or request
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
strings
strings issues (C++ and Python)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
nvtext::minhash()
function to compute the MinHash of strings in a string column without needing extra memory to hold the intermediate substrings and hash values.This also uses the
MurmurHash3_32
algorithm directly so the hash results have better parity with external algorithms. The API also accepts a hash seed value.Closes #12950
Checklist