Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address feedback from 13289 #13306

Merged
merged 1 commit into from
May 8, 2023
Merged

Address feedback from 13289 #13306

merged 1 commit into from
May 8, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 5, 2023

Description

This PR addresses a couple of minor items that were left incomplete when #13289 was merged, see #13289 and #13289.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 5, 2023
@vyasr vyasr requested a review from a team as a code owner May 5, 2023 23:58
@vyasr vyasr self-assigned this May 5, 2023
@github-actions github-actions bot added the conda label May 5, 2023
@vyasr vyasr mentioned this pull request May 5, 2023
Merged
3 tasks
@vyasr
Copy link
Contributor Author

vyasr commented May 8, 2023

CC @bdice @pentschev

pentschev
pentschev approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vyasr .

@pentschev
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 5b534a3 into rapidsai:branch-23.06 May 8, 2023
52 checks passed
@vyasr vyasr deleted the cuda12_wheel_feedback branch January 23, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@pentschev pentschev pentschev approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@vyasr vyasr

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vyasr @pentschev @bdice @ajschmidt8