Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove null mask and null count from column_view constructors #13311

Merged
merged 7 commits into from
May 16, 2023
Merged

Remove null mask and null count from column_view constructors #13311

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8a97823
Remove default null count parameter in column_view constructors
vyasr May 8, 2023
8af2c09
Explicitly pass the null mask and null count everywhere that they wer…
vyasr May 11, 2023
52bb331
Update JNI
vyasr May 11, 2023
4a60e16
Merge remote-tracking branch 'origin/branch-23.06' into feat/column_v…
vyasr May 11, 2023
4beb717
Address PR comments
vyasr May 12, 2023
4440482
Update docstrings
vyasr May 16, 2023
881bf41
Merge branch 'branch-23.06' into feat/column_view_null_count
vyasr May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cpp/include/cudf/column/column_view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ class column_view_base {
size_type size,
void const* data,
bitmask_type const* null_mask = nullptr,
size_type null_count = UNKNOWN_NULL_COUNT,
size_type null_count = 0,
vyasr marked this conversation as resolved.
Show resolved Hide resolved
size_type offset = 0);
};

Expand Down Expand Up @@ -385,7 +385,7 @@ class column_view : public detail::column_view_base {
size_type size,
void const* data,
bitmask_type const* null_mask = nullptr,
size_type null_count = UNKNOWN_NULL_COUNT,
size_type null_count = 0,
size_type offset = 0,
std::vector<column_view> const& children = {});

Expand Down Expand Up @@ -540,7 +540,7 @@ class mutable_column_view : public detail::column_view_base {
size_type size,
void* data,
bitmask_type* null_mask = nullptr,
size_type null_count = cudf::UNKNOWN_NULL_COUNT,
size_type null_count = 0,
size_type offset = 0,
std::vector<mutable_column_view> const& children = {});

Expand Down