Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove numba JIT kernel usage from dataframe copy tests #13385

Merged
merged 4 commits into from
May 18, 2023
Merged

Remove numba JIT kernel usage from dataframe copy tests #13385

merged 4 commits into from
May 18, 2023

Conversation

brandon-b-miller
Copy link
Contributor

This modernizes a few copy tests that came up during conversation at https://github.com/rapidsai/cudf/pull/13337/files#r1197942788

@brandon-b-miller brandon-b-miller added feature request New feature or request non-breaking Non-breaking change python labels May 18, 2023
@brandon-b-miller brandon-b-miller self-assigned this May 18, 2023
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner May 18, 2023 18:21
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 18, 2023
bdice
bdice requested changes May 18, 2023
View reviewed changes
python/cudf/cudf/tests/test_dataframe_copy.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_dataframe_copy.py Show resolved Hide resolved
python/cudf/cudf/tests/test_dataframe_copy.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_dataframe_copy.py Show resolved Hide resolved
@brandon-b-miller @bdice
Apply suggestions from code review
83bc735 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
bdice
bdice approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small tweaks to naming/spacing, otherwise LGTM. This is safer and clearer than using Numba.

python/cudf/cudf/tests/test_dataframe_copy.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_dataframe_copy.py Show resolved Hide resolved
python/cudf/cudf/tests/test_dataframe_copy.py Show resolved Hide resolved
brandon-b-miller and others added 2 commits May 18, 2023 14:38
@brandon-b-miller @bdice
Apply suggestions from code review
cbd00dc 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@brandon-b-miller
add missing import
52bba09
@brandon-b-miller
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 58d1c0e into rapidsai:branch-23.06 May 18, 2023
51 checks passed
@brandon-b-miller brandon-b-miller mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@brandon-b-miller brandon-b-miller

Labels
feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandon-b-miller @bdice