New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate io-text and nvtext pytests into different files #13435
Separate io-text and nvtext pytests into different files #13435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please edit these exclude paths so that the smart quotes are retained in the new location for these tests? Thanks!
Lines 83 to 89 in 19554a1
- id: fix-smartquotes | |
exclude: | | |
(?x)^( | |
^cpp/include/cudf_test/cxxopts.hpp| | |
^python/cudf/cudf/tests/data/subword_tokenizer_data/.*| | |
^python/cudf/cudf/tests/test_text.py | |
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shwina Since you recently worked on pytest organization do you think we should organize these tests into a sub-dir?
Yes, this is a good opportunity to do that.
|
@@ -1 +1,164 @@ | |||
# Copyright (c) 2023, NVIDIA CORPORATION. | |||
# Copyright (c) 2019-2023, NVIDIA CORPORATION. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved from python/cudf/cudf/tests/test_text.py
FWIW, the empty test file was a deliberate part of #12288 Not sure if we want to delete it in this change set. |
Resolved my main request, want to avoid blocking if others approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidwendt
/merge |
Description
Cleans up source files for nvtext and io-text pytests. The pytests are placed into separate files:
test_io_text.py
for the io-text pytests andtest_nvtext.py
for the nvtext pytests. Also removed thepython/cudf/cudf/tests/text
folder which contained 2 empty.py
files.Checklist