Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate io-text and nvtext pytests into different files #13435

Merged
merged 9 commits into from May 26, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented May 24, 2023

Description

Cleans up source files for nvtext and io-text pytests. The pytests are placed into separate files: test_io_text.py for the io-text pytests and test_nvtext.py for the nvtext pytests. Also removed the python/cudf/cudf/tests/text folder which contained 2 empty .py files.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress cuDF (Python) Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 24, 2023
@davidwendt davidwendt self-assigned this May 24, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 24, 2023
@davidwendt davidwendt marked this pull request as ready for review May 24, 2023 20:07
@davidwendt davidwendt requested a review from a team as a code owner May 24, 2023 20:07
bdice
bdice previously requested changes May 24, 2023
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please edit these exclude paths so that the smart quotes are retained in the new location for these tests? Thanks!

- id: fix-smartquotes
exclude: |
(?x)^(
^cpp/include/cudf_test/cxxopts.hpp|
^python/cudf/cudf/tests/data/subword_tokenizer_data/.*|
^python/cudf/cudf/tests/test_text.py
)

Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shwina Since you recently worked on pytest organization do you think we should organize these tests into a sub-dir?

@shwina
Copy link
Contributor

shwina commented May 24, 2023

Yes, this is a good opportunity to do that.

  • the "nvtext" tests should go in cudf/tests/strings/test_string_methods.py
  • the "io-text" tests should go in cudf/tests/input_output/test_text.py

@@ -1 +1,164 @@
# Copyright (c) 2023, NVIDIA CORPORATION.
# Copyright (c) 2019-2023, NVIDIA CORPORATION.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved from python/cudf/cudf/tests/test_text.py

@davidwendt davidwendt requested a review from bdice May 24, 2023 21:02
@wence-
Copy link
Contributor

wence- commented May 24, 2023

FWIW, the empty test file was a deliberate part of #12288

Not sure if we want to delete it in this change set.

@bdice bdice dismissed their stale review May 24, 2023 22:40

Resolved my main request, want to avoid blocking if others approve.

Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidwendt

@wence-
Copy link
Contributor

wence- commented May 26, 2023

/merge

@rapids-bot rapids-bot bot merged commit cc317ed into rapidsai:branch-23.08 May 26, 2023
55 checks passed
@davidwendt davidwendt deleted the text-io-nvtext-sep branch May 26, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team cuDF (Python) Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants