Expand JIT groupby test suite #13813
Conversation
brandon-b-miller
added
feature request
|
Marking this ready for review - I am going to work on solving some of the |
There was a problem hiding this comment.
@brandon-b-miller Just to clarify, you're planning to merge this to introduce new xfailed tests, then fix them in subsequent PRs?
Correct, this is my plan, based on not knowing how long it might take to fix some of these. |
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
|
/ok to test |
|
/ok to test |
| np.random.seed(0) | ||
| def groupby_jit_data_small(): | ||
| """ | ||
| Small dataset for testing groupby apply with jit |
There was a problem hiding this comment.
Can we write this comment with complete sentences / capitalization? It also feels like it's wrapped pretty harshly, like 50-60 chars / line? Same request for other comments below.
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
|
/ok to test |
|
/ok to test |
|
/merge |
This PR reorganizes and expands the test suite for groupby apply functions using the JIT engine to include nan cases and cases where the groups are larger than a single thread block.