Fix Series.setitem #13888
Closed
Fix Series.setitem #13888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wence-
reviewed
Aug 16, 2023
Comment on lines
+303
to
+311
| if isinstance(self._frame.index, cudf.RangeIndex): | ||
| new_idx = _try_append_to_range_index(self._frame.index, key) | ||
| if new_idx is not None: | ||
| self._frame._index = new_idx | ||
| else: | ||
| self._frame.index = self._frame.index._as_int_index() | ||
| _append_new_row_inplace(self._frame.index._values, key) | ||
| else: | ||
| _append_new_row_inplace(self._frame.index._values, key) |
There was a problem hiding this comment.
Just to note (and this is not a new bug). It's unsafe to append to an index inplace, since indices are immutable, so they are allowed to be shared. Witness:
import cudf
s = cudf.Series([1], index=[7])
s2 = cudf.Series([2], index=s.index) # safe because indices are immutable
s.loc[11] = 2 # uh-oh, we lied about immutability
print(s2) # this breaks because the index is too long
|
The underlying issue was resolved in 66fdbe7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #13860
This PR is WIP.
Checklist