Upgrade wheels to use arrow 13 #14339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
2 - In Progress
github-actions
bot
added
libcudf
|
Before we merge this, we need rapidsai/ci-imgs#87 merged and we need to make a corresponding PR to https://github.com/rapidsai/shared-workflows/ that enables building 2.28 wheels in addition to 2.17 wheels. We then need to update the workflows in this repo to trigger the extra 2.28 build. |
vyasr
force-pushed
the
feat/arrow_13_wheel
branch
from
b683f9f
to
d92161e
Compare
|
rapidsai/ci-imgs#87 and rapidsai/ci-imgs#88 are merged. We should be able to merge this once rapidsai/shared-workflows#150 is merged (and once #14344 is merged to unblock cudf CI). |
galipremsagar
approved these changes
Oct 30, 2023
robertmaynard
approved these changes
Oct 30, 2023
bdice
reviewed
Oct 30, 2023
raydouglass
approved these changes
Oct 30, 2023
raydouglass
requested changes
Oct 30, 2023
bdice
requested changes
Oct 30, 2023
bdice
approved these changes
Oct 30, 2023
raydouglass
approved these changes
Oct 30, 2023
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
#14339 added the ability to build cudf wheels against a newer manylinux, but those jobs were not added to the build matrix, only the PR matrix, so the newer ABI wheels aren't currently being published. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #14351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #14330 we upgraded to Arrow 13. However, we only did so for conda packages. For wheels, we couldn't do the same because pyarrow 13 started supporting two manylinux versions, both 2.17 and 2.28. This results in ABI compatibility issues because cudf wheels bundle an identical libarrow and was previously configured to compile with the CXX11 ABI turned off for compatibility with the libarrow in the 2.17 wheels. To address this, this PR modifies the CMake logic to only set that flag conditionally based on the glibc version on the host system.
Checklist