-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to fmt 10.1.1 and spdlog 1.12.0. #14355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
I'll test rapidsai/gha-tools#85 in this PR once it's available. |
Revert changes that use CI artifacts and the upstream rapids-cmake branch before merging. |
AyodeAwe
approved these changes
Nov 30, 2023
vyasr
approved these changes
Nov 30, 2023
/merge |
PointKernel
approved these changes
Nov 30, 2023
raydouglass
approved these changes
Nov 30, 2023
raydouglass
pushed a commit
to rapidsai/ucxx
that referenced
this pull request
Nov 30, 2023
This PR updates to fmt 10.1.1 and spdlog 1.12. Depends on rapidsai/cudf#14355. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Jake Awe (https://github.com/AyodeAwe) - Lawrence Mitchell (https://github.com/wence-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to fmt 10.1.1 and spdlog 1.12.
Depends on rapidsai/rmm#1374.