Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: Make DataFrame.from_pandas process by column #14483

Merged
merged 8 commits into from
Nov 28, 2023
Merged

REF: Make DataFrame.from_pandas process by column #14483

merged 8 commits into from
Nov 28, 2023

Conversation

mroeschke
Copy link
Contributor

Description

Also encountered a bug where cudf.Index.from_pandas would return an cudf.Index[int64] from a pandas.RangeIndex

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Nov 23, 2023
@mroeschke mroeschke requested a review from a team as a code owner November 23, 2023 01:17
wence-
wence- approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. Reran the one failed test.

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5e58e71 into rapidsai:branch-24.02 Nov 28, 2023
67 checks passed
@mroeschke mroeschke deleted the ref/dataframe/from_pandas branch November 28, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mroeschke @wence-